fix(java): Allow frame removals during symbolication#104319
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104319 +/- ##
===========================================
+ Coverage 80.56% 80.60% +0.03%
===========================================
Files 9340 9339 -1
Lines 399156 399176 +20
Branches 25552 25552
===========================================
+ Hits 321595 321750 +155
+ Misses 77122 76987 -135
Partials 439 439 |
loewenheim
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the introduction of getsentry/symbolicator#1817 Symbolicator can actually remove frames, not only expand/remap them, so this change is necessary to not display synthetic frames generated by R8/proguard.
NOTE: We only apply this logic for
javaframes to account for mixed stacktraces.Before
After